Hands down, one hour before sunset is ideal. I would even stretch it to 45 minutes before sunset, too. Thing is, after the sun sets, there's still light in the sky and it's actually quite nice! You may have heard photographers reference "golden hour" before.