Yellow can work on a black background, but it's as much about fonts and where the colour is used that affect the overall look of the site. Make sure you're using fonts that are easily legible and you only use yellow for highlighting, as you have done.